mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-12-04 00:30:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Issue #10955: Fix a potential crash when trying to mmap() a file past its

Browse source 
length.  Initial patch by Ross Lagerwall.

This fixes a regression introduced by r88022.
This commit is contained in:
Antoine Pitrou 2011-01-20 21:07:24 +00:00
parent 9ee94dec18
commit 305bc9e0e8
3 changed files with 27 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Modules/mmapmodule.c
View file

@ -1116,6 +1116,11 @@ new_mmap_object(PyTypeObject *type, PyObject *args, PyObject *kwdict)
# endif
if (fd != -1 && fstat(fd, &st) == 0 && S_ISREG(st.st_mode)) {
if (map_size == 0) {
if (offset >= st.st_size) {
PyErr_SetString(PyExc_ValueError,
"mmap offset is greater than file size");
return NULL;
}
map_size = st.st_size - offset;
} else if ((size_t)offset + (size_t)map_size > st.st_size) {
PyErr_SetString(PyExc_ValueError,
@ -1300,6 +1305,12 @@ new_mmap_object(PyTypeObject *type, PyObject *args, PyObject *kwdict)
else
m_obj->size = low;
#endif
if (offset >= m_obj->size) {
PyErr_SetString(PyExc_ValueError,
"mmap offset is greater than file size");
Py_DECREF(m_obj);
return NULL;
}
m_obj->size -= offset;
} else {
m_obj->size = map_size;