mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-04 17:08:35 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 13

bpo-46018: Ensure that math.expm1 does not raise on underflow (GH-29997)

Browse source
This commit is contained in:
Steve Dower 2021-12-09 18:31:54 +00:00 • committed by GitHub
parent 44b0e76f2a
commit 3363e1cb05
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Misc/NEWS.d/next/Library/2021-12-09-00-44-42.bpo-46018.hkTI7v.rst Normal file
View file

@ -0,0 +1 @@
Ensure that :func:`math.expm1` does not raise on underflow.

8
Modules/mathmodule.c
View file

@ -985,9 +985,13 @@ is_error(double x)
* On some platforms (Ubuntu/ia64) it seems that errno can be
* set to ERANGE for subnormal results that do *not* underflow
* to zero. So to be safe, we'll ignore ERANGE whenever the
* function result is less than one in absolute value.
* function result is less than 1.5 in absolute value.
*
* bpo-46018: Changed to 1.5 to ensure underflows in expm1()
* are correctly detected, since the function may underflow
* toward -1.0 rather than 0.0.
*/
if (fabs(x) < 1.0)
if (fabs(x) < 1.5)
result = 0;
else
PyErr_SetString(PyExc_OverflowError,