mirror of
https://github.com/python/cpython.git
synced 2025-08-09 19:38:42 +00:00
bpo-42140: Improve asyncio.wait function (GH-22938)
GH- Improve asyncio.wait function
The original code creates the futures set two times.
We can create this set before, avoiding the second creation.
This new behaviour [breaks the aiokafka library](https://github.com/aio-libs/aiokafka/pull/672), because it gives an iterator to that function, so the second iteration become empty.
Automerge-Triggered-By: GH:1st1
(cherry picked from commit 7e5ef0a571
)
Co-authored-by: Diogo Dutra <diogodutradamata@gmail.com>
This commit is contained in:
parent
f8bea0a44d
commit
33922cb0aa
3 changed files with 29 additions and 2 deletions
|
@ -1548,6 +1548,30 @@ class BaseTaskTests:
|
|||
loop.advance_time(10)
|
||||
loop.run_until_complete(asyncio.wait([a, b]))
|
||||
|
||||
def test_wait_with_iterator_of_tasks(self):
|
||||
|
||||
def gen():
|
||||
when = yield
|
||||
self.assertAlmostEqual(0.1, when)
|
||||
when = yield 0
|
||||
self.assertAlmostEqual(0.15, when)
|
||||
yield 0.15
|
||||
|
||||
loop = self.new_test_loop(gen)
|
||||
|
||||
a = self.new_task(loop, asyncio.sleep(0.1))
|
||||
b = self.new_task(loop, asyncio.sleep(0.15))
|
||||
|
||||
async def foo():
|
||||
done, pending = await asyncio.wait(iter([b, a]))
|
||||
self.assertEqual(done, set([a, b]))
|
||||
self.assertEqual(pending, set())
|
||||
return 42
|
||||
|
||||
res = loop.run_until_complete(self.new_task(loop, foo()))
|
||||
self.assertEqual(res, 42)
|
||||
self.assertAlmostEqual(0.15, loop.time())
|
||||
|
||||
def test_as_completed(self):
|
||||
|
||||
def gen():
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue