mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-09-26 18:29:57 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

gh-92886: [clinic.py] raise exception on invalid input instead of assertion (GH-98051)

Browse source 
Tests should pass with -O (assertions off).

Automerge-Triggered-By: GH:iritkatriel
This commit is contained in:
Irit Katriel 2022-10-07 22:41:35 +01:00 • committed by GitHub
parent 3de08ce8c1
commit 34e6f3567e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Lib/test/test_clinic.py
View file

@ -153,7 +153,7 @@ class ClinicGroupPermuterTest(TestCase):
def test_have_left_options_but_required_is_empty(self): def test_have_left_options_but_required_is_empty(self):
def fn(): def fn():
clinic.permute_optional_groups(['a'], [], []) clinic.permute_optional_groups(['a'], [], [])
self.assertRaises(AssertionError, fn) self.assertRaises(ValueError, fn)
class ClinicLinearFormatTest(TestCase): class ClinicLinearFormatTest(TestCase):

3
Tools/clinic/clinic.py
View file

@ -495,7 +495,8 @@ def permute_optional_groups(left, required, right):
result = [] result = []
if not required: if not required:
assert not left if left:
raise ValueError("required is empty but left is not")
accumulator = [] accumulator = []
counts = set() counts = set()