mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-03 00:23:06 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

* regression bug, count_next was coercing a Py_ssize_t to an unsigned Py_size_t

Browse source 
which breaks negative counts
* added test for negative numbers
will backport to 2.5.1
This commit is contained in:
Jack Diederich 2006-09-21 17:50:26 +00:00
parent d14bf61d05
commit 36234e8f66
2 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Lib/test/test_itertools.py
View file

@ -58,6 +58,10 @@ class TestBasicOps(unittest.TestCase):
self.assertEqual(repr(c), 'count(3)')
c.next()
self.assertEqual(repr(c), 'count(4)')
c = count(-9)
self.assertEqual(repr(c), 'count(-9)')
c.next()
self.assertEqual(c.next(), -8)
def test_cycle(self):
self.assertEqual(take(10, cycle('abc')), list('abcabcabca'))

2
Modules/itertoolsmodule.c
View file

@ -2072,7 +2072,7 @@ count_new(PyTypeObject *type, PyObject *args, PyObject *kwds)
static PyObject *
count_next(countobject *lz)
{
return PyInt_FromSize_t(lz->cnt++);
return PyInt_FromSsize_t(lz->cnt++);
}
static PyObject *