mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-03 16:39:00 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

remove __del__ because it's evil and also prevents the ResourceWarning on the socket from happening (closes #16900)

Browse source
This commit is contained in:
Benjamin Peterson 2013-01-10 14:16:20 -06:00
parent 7bd04867e5
commit 36f7b97787
3 changed files with 10 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Lib/test/test_ssl.py
View file

@ -374,6 +374,14 @@ class BasicSocketTests(unittest.TestCase):
ss = ssl.wrap_socket(s, server_side=True, certfile=CERTFILE)
self.assertIsNone(ss.get_channel_binding("tls-unique"))
def test_dealloc_warn(self):
ss = ssl.wrap_socket(socket.socket(socket.AF_INET))
r = repr(ss)
with self.assertWarns(ResourceWarning) as cm:
ss = None
support.gc_collect()
self.assertIn(r, str(cm.warning.args[0]))
class ContextTests(unittest.TestCase):
@skip_if_broken_ubuntu_ssl