mirror of
https://github.com/python/cpython.git
synced 2025-08-04 00:48:58 +00:00
Merge 3.5.1rc1 release changes back into main 3.5 branch.
This commit is contained in:
commit
3715cab3cb
9 changed files with 201 additions and 24 deletions
|
@ -1105,6 +1105,29 @@ class TestShutil(unittest.TestCase):
|
|||
names2 = zf.namelist()
|
||||
self.assertEqual(sorted(names), sorted(names2))
|
||||
|
||||
@requires_zlib
|
||||
@unittest.skipUnless(ZIP_SUPPORT, 'Need zip support to run')
|
||||
@unittest.skipUnless(shutil.which('unzip'),
|
||||
'Need the unzip command to run')
|
||||
def test_unzip_zipfile(self):
|
||||
root_dir, base_dir = self._create_files()
|
||||
base_name = os.path.join(self.mkdtemp(), 'archive')
|
||||
archive = make_archive(base_name, 'zip', root_dir, base_dir)
|
||||
|
||||
# check if ZIP file was created
|
||||
self.assertEqual(archive, base_name + '.zip')
|
||||
self.assertTrue(os.path.isfile(archive))
|
||||
|
||||
# now check the ZIP file using `unzip -t`
|
||||
zip_cmd = ['unzip', '-t', archive]
|
||||
with support.change_cwd(root_dir):
|
||||
try:
|
||||
subprocess.check_output(zip_cmd, stderr=subprocess.STDOUT)
|
||||
except subprocess.CalledProcessError as exc:
|
||||
details = exc.output.decode(errors="replace")
|
||||
msg = "{}\n\n**Unzip Output**\n{}"
|
||||
self.fail(msg.format(exc, details))
|
||||
|
||||
def test_make_archive(self):
|
||||
tmpdir = self.mkdtemp()
|
||||
base_name = os.path.join(tmpdir, 'archive')
|
||||
|
|
|
@ -244,6 +244,33 @@ class ElementTreeTest(unittest.TestCase):
|
|||
self.assertEqual(ET.XML, ET.fromstring)
|
||||
self.assertEqual(ET.PI, ET.ProcessingInstruction)
|
||||
|
||||
def test_set_attribute(self):
|
||||
element = ET.Element('tag')
|
||||
|
||||
self.assertEqual(element.tag, 'tag')
|
||||
element.tag = 'Tag'
|
||||
self.assertEqual(element.tag, 'Tag')
|
||||
element.tag = 'TAG'
|
||||
self.assertEqual(element.tag, 'TAG')
|
||||
|
||||
self.assertIsNone(element.text)
|
||||
element.text = 'Text'
|
||||
self.assertEqual(element.text, 'Text')
|
||||
element.text = 'TEXT'
|
||||
self.assertEqual(element.text, 'TEXT')
|
||||
|
||||
self.assertIsNone(element.tail)
|
||||
element.tail = 'Tail'
|
||||
self.assertEqual(element.tail, 'Tail')
|
||||
element.tail = 'TAIL'
|
||||
self.assertEqual(element.tail, 'TAIL')
|
||||
|
||||
self.assertEqual(element.attrib, {})
|
||||
element.attrib = {'a': 'b', 'c': 'd'}
|
||||
self.assertEqual(element.attrib, {'a': 'b', 'c': 'd'})
|
||||
element.attrib = {'A': 'B', 'C': 'D'}
|
||||
self.assertEqual(element.attrib, {'A': 'B', 'C': 'D'})
|
||||
|
||||
def test_simpleops(self):
|
||||
# Basic method sanity checks.
|
||||
|
||||
|
@ -2350,6 +2377,7 @@ class ElementSlicingTest(unittest.TestCase):
|
|||
self.assertEqual(e[-2].tag, 'a8')
|
||||
|
||||
self.assertRaises(IndexError, lambda: e[12])
|
||||
self.assertRaises(IndexError, lambda: e[-12])
|
||||
|
||||
def test_getslice_range(self):
|
||||
e = self._make_elem_with_children(6)
|
||||
|
@ -2368,12 +2396,17 @@ class ElementSlicingTest(unittest.TestCase):
|
|||
self.assertEqual(self._elem_tags(e[::3]), ['a0', 'a3', 'a6', 'a9'])
|
||||
self.assertEqual(self._elem_tags(e[::8]), ['a0', 'a8'])
|
||||
self.assertEqual(self._elem_tags(e[1::8]), ['a1', 'a9'])
|
||||
self.assertEqual(self._elem_tags(e[3::sys.maxsize]), ['a3'])
|
||||
self.assertEqual(self._elem_tags(e[3::sys.maxsize<<64]), ['a3'])
|
||||
|
||||
def test_getslice_negative_steps(self):
|
||||
e = self._make_elem_with_children(4)
|
||||
|
||||
self.assertEqual(self._elem_tags(e[::-1]), ['a3', 'a2', 'a1', 'a0'])
|
||||
self.assertEqual(self._elem_tags(e[::-2]), ['a3', 'a1'])
|
||||
self.assertEqual(self._elem_tags(e[3::-sys.maxsize]), ['a3'])
|
||||
self.assertEqual(self._elem_tags(e[3::-sys.maxsize-1]), ['a3'])
|
||||
self.assertEqual(self._elem_tags(e[3::-sys.maxsize<<64]), ['a3'])
|
||||
|
||||
def test_delslice(self):
|
||||
e = self._make_elem_with_children(4)
|
||||
|
@ -2400,6 +2433,75 @@ class ElementSlicingTest(unittest.TestCase):
|
|||
del e[::2]
|
||||
self.assertEqual(self._subelem_tags(e), ['a1'])
|
||||
|
||||
def test_setslice_single_index(self):
|
||||
e = self._make_elem_with_children(4)
|
||||
e[1] = ET.Element('b')
|
||||
self.assertEqual(self._subelem_tags(e), ['a0', 'b', 'a2', 'a3'])
|
||||
|
||||
e[-2] = ET.Element('c')
|
||||
self.assertEqual(self._subelem_tags(e), ['a0', 'b', 'c', 'a3'])
|
||||
|
||||
with self.assertRaises(IndexError):
|
||||
e[5] = ET.Element('d')
|
||||
with self.assertRaises(IndexError):
|
||||
e[-5] = ET.Element('d')
|
||||
self.assertEqual(self._subelem_tags(e), ['a0', 'b', 'c', 'a3'])
|
||||
|
||||
def test_setslice_range(self):
|
||||
e = self._make_elem_with_children(4)
|
||||
e[1:3] = [ET.Element('b%s' % i) for i in range(2)]
|
||||
self.assertEqual(self._subelem_tags(e), ['a0', 'b0', 'b1', 'a3'])
|
||||
|
||||
e = self._make_elem_with_children(4)
|
||||
e[1:3] = [ET.Element('b')]
|
||||
self.assertEqual(self._subelem_tags(e), ['a0', 'b', 'a3'])
|
||||
|
||||
e = self._make_elem_with_children(4)
|
||||
e[1:3] = [ET.Element('b%s' % i) for i in range(3)]
|
||||
self.assertEqual(self._subelem_tags(e), ['a0', 'b0', 'b1', 'b2', 'a3'])
|
||||
|
||||
def test_setslice_steps(self):
|
||||
e = self._make_elem_with_children(6)
|
||||
e[1:5:2] = [ET.Element('b%s' % i) for i in range(2)]
|
||||
self.assertEqual(self._subelem_tags(e), ['a0', 'b0', 'a2', 'b1', 'a4', 'a5'])
|
||||
|
||||
e = self._make_elem_with_children(6)
|
||||
with self.assertRaises(ValueError):
|
||||
e[1:5:2] = [ET.Element('b')]
|
||||
with self.assertRaises(ValueError):
|
||||
e[1:5:2] = [ET.Element('b%s' % i) for i in range(3)]
|
||||
with self.assertRaises(ValueError):
|
||||
e[1:5:2] = []
|
||||
self.assertEqual(self._subelem_tags(e), ['a0', 'a1', 'a2', 'a3', 'a4', 'a5'])
|
||||
|
||||
e = self._make_elem_with_children(4)
|
||||
e[1::sys.maxsize] = [ET.Element('b')]
|
||||
self.assertEqual(self._subelem_tags(e), ['a0', 'b', 'a2', 'a3'])
|
||||
e[1::sys.maxsize<<64] = [ET.Element('c')]
|
||||
self.assertEqual(self._subelem_tags(e), ['a0', 'c', 'a2', 'a3'])
|
||||
|
||||
def test_setslice_negative_steps(self):
|
||||
e = self._make_elem_with_children(4)
|
||||
e[2:0:-1] = [ET.Element('b%s' % i) for i in range(2)]
|
||||
self.assertEqual(self._subelem_tags(e), ['a0', 'b1', 'b0', 'a3'])
|
||||
|
||||
e = self._make_elem_with_children(4)
|
||||
with self.assertRaises(ValueError):
|
||||
e[2:0:-1] = [ET.Element('b')]
|
||||
with self.assertRaises(ValueError):
|
||||
e[2:0:-1] = [ET.Element('b%s' % i) for i in range(3)]
|
||||
with self.assertRaises(ValueError):
|
||||
e[2:0:-1] = []
|
||||
self.assertEqual(self._subelem_tags(e), ['a0', 'a1', 'a2', 'a3'])
|
||||
|
||||
e = self._make_elem_with_children(4)
|
||||
e[1::-sys.maxsize] = [ET.Element('b')]
|
||||
self.assertEqual(self._subelem_tags(e), ['a0', 'b', 'a2', 'a3'])
|
||||
e[1::-sys.maxsize-1] = [ET.Element('c')]
|
||||
self.assertEqual(self._subelem_tags(e), ['a0', 'c', 'a2', 'a3'])
|
||||
e[1::-sys.maxsize<<64] = [ET.Element('d')]
|
||||
self.assertEqual(self._subelem_tags(e), ['a0', 'd', 'a2', 'a3'])
|
||||
|
||||
|
||||
class IOTest(unittest.TestCase):
|
||||
def tearDown(self):
|
||||
|
|
|
@ -22,6 +22,38 @@ class MiscTests(unittest.TestCase):
|
|||
finally:
|
||||
data = None
|
||||
|
||||
def test_del_attribute(self):
|
||||
element = cET.Element('tag')
|
||||
|
||||
element.tag = 'TAG'
|
||||
with self.assertRaises(AttributeError):
|
||||
del element.tag
|
||||
self.assertEqual(element.tag, 'TAG')
|
||||
|
||||
with self.assertRaises(AttributeError):
|
||||
del element.text
|
||||
self.assertIsNone(element.text)
|
||||
element.text = 'TEXT'
|
||||
with self.assertRaises(AttributeError):
|
||||
del element.text
|
||||
self.assertEqual(element.text, 'TEXT')
|
||||
|
||||
with self.assertRaises(AttributeError):
|
||||
del element.tail
|
||||
self.assertIsNone(element.tail)
|
||||
element.tail = 'TAIL'
|
||||
with self.assertRaises(AttributeError):
|
||||
del element.tail
|
||||
self.assertEqual(element.tail, 'TAIL')
|
||||
|
||||
with self.assertRaises(AttributeError):
|
||||
del element.attrib
|
||||
self.assertEqual(element.attrib, {})
|
||||
element.attrib = {'A': 'B', 'C': 'D'}
|
||||
with self.assertRaises(AttributeError):
|
||||
del element.attrib
|
||||
self.assertEqual(element.attrib, {'A': 'B', 'C': 'D'})
|
||||
|
||||
|
||||
@unittest.skipUnless(cET, 'requires _elementtree')
|
||||
class TestAliasWorking(unittest.TestCase):
|
||||
|
|
|
@ -1444,7 +1444,9 @@ class ZipFile:
|
|||
arcname += '/'
|
||||
zinfo = ZipInfo(arcname, date_time)
|
||||
zinfo.external_attr = (st[0] & 0xFFFF) << 16 # Unix attributes
|
||||
if compress_type is None:
|
||||
if isdir:
|
||||
zinfo.compress_type = ZIP_STORED
|
||||
elif compress_type is None:
|
||||
zinfo.compress_type = self.compression
|
||||
else:
|
||||
zinfo.compress_type = compress_type
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue