mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-02 16:13:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

support: temp_dir() and change_cwd() uses repr() in error message

Browse source 
Serhiy Storshaka pointed me that str(path) can emit a BytesWarning: use
repr(path) instead.
This commit is contained in:
Victor Stinner 2017-02-08 15:49:10 +01:00
parent 620580f280
commit 3722f1f483
2 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Lib/test/support/__init__.py
View file

@ -958,7 +958,7 @@ def temp_dir(path=None, quiet=False):
if not quiet:
raise
warnings.warn(f'tests may fail, unable to create '
f'temporary directory {path}: {exc}',
f'temporary directory {path!r}: {exc}',
RuntimeWarning, stacklevel=3)
try:
yield path
@ -986,7 +986,7 @@ def change_cwd(path, quiet=False):
if not quiet:
raise
warnings.warn(f'tests may fail, unable to change the current working '
f'directory to {path}: {exc}',
f'directory to {path!r}: {exc}',
RuntimeWarning, stacklevel=3)
try:
yield os.getcwd()

6
Lib/test/test_support.py
View file

@ -158,7 +158,7 @@ class TestSupport(unittest.TestCase):
self.assertEqual(len(warnings), 1, warnings)
warn = warnings[0]
self.assertTrue(warn.startswith(f'tests may fail, unable to create '
f'temporary directory {path}: '),
f'temporary directory {path!r}: '),
warn)
# Tests for change_cwd()
@ -204,7 +204,7 @@ class TestSupport(unittest.TestCase):
warn = warnings[0]
self.assertTrue(warn.startswith(f'tests may fail, unable to change '
f'the current working directory '
f'to {bad_dir}: '),
f'to {bad_dir!r}: '),
warn)
# Tests for change_cwd()
@ -221,7 +221,7 @@ class TestSupport(unittest.TestCase):
msg = messages[0]
self.assertTrue(msg.startswith(f'tests may fail, unable to change '
f'the current working directory '
f'to {path}: '),
f'to {path!r}: '),
msg)
# Tests for temp_cwd()