mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-31 14:07:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

(merge 3.2) Close #12383: Fix subprocess module with env={}: don't copy the

Browse source 
environment variables, start with an empty environment.
This commit is contained in:
Victor Stinner 2011-06-21 17:24:21 +02:00
commit 372b838db5
3 changed files with 20 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

23
Lib/test/test_subprocess.py
View file

@ -382,13 +382,22 @@ class ProcessTestCase(BaseTestCase):
def test_env(self):
newenv = os.environ.copy()
newenv["FRUIT"] = "orange"
p = subprocess.Popen([sys.executable, "-c",
'import sys,os;'
'sys.stdout.write(os.getenv("FRUIT"))'],
stdout=subprocess.PIPE,
env=newenv)
self.addCleanup(p.stdout.close)
self.assertEqual(p.stdout.read(), b"orange")
with subprocess.Popen([sys.executable, "-c",
'import sys,os;'
'sys.stdout.write(os.getenv("FRUIT"))'],
stdout=subprocess.PIPE,
env=newenv) as p:
stdout, stderr = p.communicate()
self.assertEqual(stdout, b"orange")
def test_empty_env(self):
with subprocess.Popen([sys.executable, "-c",
'import os; '
'print(len(os.environ))'],
stdout=subprocess.PIPE,
env={}) as p:
stdout, stderr = p.communicate()
self.assertEqual(stdout.strip(), b"0")
def test_communicate_stdin(self):
p = subprocess.Popen([sys.executable, "-c",