mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-04 00:48:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

gh-95804: Respect MemoryHandler.flushOnClose in logging shutdown. (GH-95857)

Browse source
This commit is contained in:
David Bonner 2022-08-10 13:08:55 -04:00 • committed by GitHub
parent 71c3d649b5
commit 37c0f9ccc0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 37 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

29
Lib/test/test_logging.py
View file

@ -1225,6 +1225,35 @@ class MemoryHandlerTest(BaseTest):
# assert that no new lines have been added
self.assert_log_lines(lines) # no change
def test_shutdown_flush_on_close(self):
"""
Test that the flush-on-close configuration is respected by the
shutdown method.
"""
self.mem_logger.debug(self.next_message())
self.assert_log_lines([])
self.mem_logger.info(self.next_message())
self.assert_log_lines([])
# Default behaviour is to flush on close. Check that it happens.
logging.shutdown(handlerList=[logging.weakref.ref(self.mem_hdlr)])
lines = [
('DEBUG', '1'),
('INFO', '2'),
]
self.assert_log_lines(lines)
# Now configure for flushing not to be done on close.
self.mem_hdlr = logging.handlers.MemoryHandler(10, logging.WARNING,
self.root_hdlr,
False)
self.mem_logger.addHandler(self.mem_hdlr)
self.mem_logger.debug(self.next_message())
self.assert_log_lines(lines) # no change
self.mem_logger.info(self.next_message())
self.assert_log_lines(lines) # no change
# assert that no new lines have been added after shutdown
logging.shutdown(handlerList=[logging.weakref.ref(self.mem_hdlr)])
self.assert_log_lines(lines) # no change
@threading_helper.requires_working_threading()
def test_race_between_set_target_and_flush(self):
class MockRaceConditionHandler: