[3.13] gh-111201: Improve pyrepl auto indentation (GH-119606) (GH-119833)

- auto-indent when editing multi-line block
- ignore comments

(cherry picked from commit dae0375bd9)

Co-authored-by: Arnon Yaari <wiggin15@yahoo.com>
This commit is contained in:
Miss Islington (bot) 2024-05-31 11:51:53 +02:00 committed by GitHub
parent 7dae73b21b
commit 38bf39cb4b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 101 additions and 11 deletions

View file

@ -312,6 +312,14 @@ class TestCursorPosition(TestCase):
self.assertEqual(reader.pos, 10)
self.assertEqual(reader.cxy, (1, 1))
class TestPyReplAutoindent(TestCase):
def prepare_reader(self, events):
console = FakeConsole(events)
config = ReadlineConfig(readline_completer=None)
reader = ReadlineAlikeReader(console=console, config=config)
return reader
def test_auto_indent_default(self):
# fmt: off
input_code = (
@ -372,7 +380,6 @@ class TestCursorPosition(TestCase):
),
)
output_code = (
"def g():\n"
" pass\n"
@ -385,6 +392,78 @@ class TestCursorPosition(TestCase):
output2 = multiline_input(reader)
self.assertEqual(output2, output_code)
def test_auto_indent_multiline(self):
# fmt: off
events = itertools.chain(
code_to_events(
"def f():\n"
"pass"
),
[
# go to the end of the first line
Event(evt="key", data="up", raw=bytearray(b"\x1bOA")),
Event(evt="key", data="\x05", raw=bytearray(b"\x1bO5")),
# new line should be autoindented
Event(evt="key", data="\n", raw=bytearray(b"\n")),
],
code_to_events(
"pass"
),
[
# go to end of last line
Event(evt="key", data="down", raw=bytearray(b"\x1bOB")),
Event(evt="key", data="\x05", raw=bytearray(b"\x1bO5")),
# double newline to terminate the block
Event(evt="key", data="\n", raw=bytearray(b"\n")),
Event(evt="key", data="\n", raw=bytearray(b"\n")),
],
)
output_code = (
"def f():\n"
" pass\n"
" pass\n"
" "
)
# fmt: on
reader = self.prepare_reader(events)
output = multiline_input(reader)
self.assertEqual(output, output_code)
def test_auto_indent_with_comment(self):
# fmt: off
events = code_to_events(
"def f(): # foo\n"
"pass\n\n"
)
output_code = (
"def f(): # foo\n"
" pass\n"
" "
)
# fmt: on
reader = self.prepare_reader(events)
output = multiline_input(reader)
self.assertEqual(output, output_code)
def test_auto_indent_ignore_comments(self):
# fmt: off
events = code_to_events(
"pass #:\n"
)
output_code = (
"pass #:"
)
# fmt: on
reader = self.prepare_reader(events)
output = multiline_input(reader)
self.assertEqual(output, output_code)
class TestPyReplOutput(TestCase):
def prepare_reader(self, events):