mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-04 00:48:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

gh-117344: Skip flaky tests in free-threaded build (#117355)

Browse source 
The tests are not reliable with the GIL disabled. In theory, they can
fail with the GIL enabled too, but the failures are much more likely
with the GIL disabled.
This commit is contained in:
Sam Gross 2024-03-29 13:34:04 -04:00 • committed by GitHub
parent f05fb2e65c
commit 397d88db5e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 2 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Lib/test/test_concurrent_futures/test_process_pool.py
View file

@ -116,6 +116,7 @@ class ProcessPoolExecutorTest(ExecutorTest):
for _ in range(job_count):
sem.release()
@unittest.skipIf(support.Py_GIL_DISABLED, "gh-117344: test is flaky without the GIL")
def test_idle_process_reuse_one(self):
executor = self.executor
assert executor._max_workers >= 4

1
Lib/test/test_concurrent_futures/test_thread_pool.py
View file

@ -41,6 +41,7 @@ class ThreadPoolExecutorTest(ThreadPoolMixin, ExecutorTest, BaseTestCase):
sem.release()
executor.shutdown(wait=True)
@unittest.skipIf(support.Py_GIL_DISABLED, "gh-117344: test is flaky without the GIL")
def test_idle_thread_reuse(self):
executor = self.executor_type()
executor.submit(mul, 21, 2).result()