mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-04 08:59:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

bpo-41322: added deprecation warning for tests returning value!=None (GH-27748)

Browse source
This commit is contained in:
andrei kulakov 2021-08-19 05:41:04 -04:00 • committed by GitHub
parent 0fd66e46b2
commit 3db42fc5ac
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 10 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Lib/unittest/async_case.py
View file

@ -1,5 +1,6 @@
import asyncio
import inspect
import warnings
from .case import TestCase
@ -62,7 +63,9 @@ class IsolatedAsyncioTestCase(TestCase):
self._callAsync(self.asyncSetUp)
def _callTestMethod(self, method):
self._callMaybeAsync(method)
if self._callMaybeAsync(method) is not None:
warnings.warn(f'It is deprecated to return a value!=None from a '
f'test case ({method})', DeprecationWarning)
def _callTearDown(self):
self._callAsync(self.asyncTearDown)

4
Lib/unittest/case.py
View file

@ -546,7 +546,9 @@ class TestCase(object):
self.setUp()
def _callTestMethod(self, method):
method()
if method() is not None:
warnings.warn(f'It is deprecated to return a value!=None from a '
f'test case ({method})', DeprecationWarning)
def _callTearDown(self):
self.tearDown()

3
Misc/NEWS.d/next/Library/2021-08-12-16-22-16.bpo-41322.utscTd.rst Normal file
View file

@ -0,0 +1,3 @@
Added ``DeprecationWarning`` for tests and async tests that return a
value!=None (as this may indicate an improperly written test, for example a
test written as a generator function).