mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-22 09:45:06 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 13

gh-115821: [Enum] better error message for calling super().__new__() (GH-116063)

Browse source 
docs now state to not call super().__new__
if super().__new__ is called, a better error message is now used
This commit is contained in:
Ethan Furman 2024-02-28 15:17:49 -08:00 • committed by GitHub
parent 4d1d35b906
commit 3ea78fd5bc
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 22 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Lib/enum.py
View file

@ -547,7 +547,10 @@ class EnumType(type):
classdict['_inverted_'] = None
try:
exc = None
classdict['_%s__in_progress' % cls] = True
enum_class = super().__new__(metacls, cls, bases, classdict, **kwds)
classdict['_%s__in_progress' % cls] = False
delattr(enum_class, '_%s__in_progress' % cls)
except Exception as e:
# since 3.12 the line "Error calling __set_name__ on '_proto_member' instance ..."
# is tacked on to the error instead of raising a RuntimeError
@ -1155,6 +1158,8 @@ class Enum(metaclass=EnumType):
# still not found -- verify that members exist, in-case somebody got here mistakenly
# (such as via super when trying to override __new__)
if not cls._member_map_:
if getattr(cls, '_%s__in_progress' % cls.__name__, False):
raise TypeError('do not use `super().__new__; call the appropriate __new__ directly') from None
raise TypeError("%r has no members defined" % cls)
#
# still not found -- try _missing_ hook