mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-12-05 00:52:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

Issue #28071: Add early-out for differencing from an empty set.

Browse source
This commit is contained in:
Raymond Hettinger 2016-09-11 22:02:28 -07:00
parent 34b74fffb3
commit 4103e4dfbc
2 changed files with 10 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Misc/NEWS
View file

@ -33,6 +33,8 @@ Core and Builtins
- Issue #28046: Remove platform-specific directories from sys.path. - Issue #28046: Remove platform-specific directories from sys.path.
- Issue #28071: Add early-out for differencing from an empty set.
- Issue #25758: Prevents zipimport from unnecessarily encoding a filename - Issue #25758: Prevents zipimport from unnecessarily encoding a filename
(patch by Eryk Sun) (patch by Eryk Sun)

8
Objects/setobject.c
View file

@ -1476,6 +1476,10 @@ PyDoc_STRVAR(isdisjoint_doc,
static int static int
set_difference_update_internal(PySetObject *so, PyObject *other) set_difference_update_internal(PySetObject *so, PyObject *other)
{ {
if (PySet_GET_SIZE(so) == 0) {
return 0;
}
if ((PyObject *)so == other) if ((PyObject *)so == other)
return set_clear_internal(so); return set_clear_internal(so);
@ -1550,6 +1554,10 @@ set_difference(PySetObject *so, PyObject *other)
Py_ssize_t pos = 0; Py_ssize_t pos = 0;
int rv; int rv;
if (PySet_GET_SIZE(so) == 0) {
return set_copy(so);
}
if (!PyAnySet_Check(other) && !PyDict_CheckExact(other)) { if (!PyAnySet_Check(other) && !PyDict_CheckExact(other)) {
return set_copy_and_difference(so, other); return set_copy_and_difference(so, other);
} }