mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-07-25 12:14:38 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Issue #23243: Fix asyncio._UnixWritePipeTransport.close()

Browse source 
Do nothing if the transport is already closed. Before it was not possible to
close the transport twice.
This commit is contained in:
Victor Stinner 2015-01-15 13:16:50 +01:00
parent 7e222f411c
commit 41ed958ee6
2 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Lib/asyncio/unix_events.py
View file

@ -516,7 +516,7 @@ class _UnixWritePipeTransport(transports._FlowControlMixin,
self._loop.call_soon(self._call_connection_lost, None) self._loop.call_soon(self._call_connection_lost, None)
def close(self): def close(self):
if not self._closing: if self._pipe is not None and not self._closing:
# write_eof is all what we needed to close the write pipe # write_eof is all what we needed to close the write pipe
self.write_eof() self.write_eof()

3
Lib/test/test_asyncio/test_unix_events.py
View file

@ -766,6 +766,9 @@ class UnixWritePipeTransportTests(test_utils.TestCase):
tr.close() tr.close()
tr.write_eof.assert_called_with() tr.write_eof.assert_called_with()
# closing the transport twice must not fail
tr.close()
def test_close_closing(self): def test_close_closing(self):
tr = unix_events._UnixWritePipeTransport( tr = unix_events._UnixWritePipeTransport(
self.loop, self.pipe, self.protocol) self.loop, self.pipe, self.protocol)