mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-09-26 18:29:57 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

bpo-34333: Fix %-formatting in Path.with_suffix() (GH-8663)

Browse source
This commit is contained in:
Berker Peksag 2018-08-11 08:45:06 +03:00 • committed by GitHub
parent 077059e0f0
commit 423d05f6f5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Lib/pathlib.py
View file

@ -813,7 +813,7 @@ class PurePath(object):
""" """
f = self._flavour f = self._flavour
if f.sep in suffix or f.altsep and f.altsep in suffix: if f.sep in suffix or f.altsep and f.altsep in suffix:
raise ValueError("Invalid suffix %r" % (suffix)) raise ValueError("Invalid suffix %r" % (suffix,))
if suffix and not suffix.startswith('.') or suffix == '.': if suffix and not suffix.startswith('.') or suffix == '.':
raise ValueError("Invalid suffix %r" % (suffix)) raise ValueError("Invalid suffix %r" % (suffix))
name = self.name name = self.name

2
Lib/test/test_pathlib.py
View file

@ -577,6 +577,8 @@ class _BasePurePathTest(object):
self.assertRaises(ValueError, P('a/b').with_suffix, '.c/.d') self.assertRaises(ValueError, P('a/b').with_suffix, '.c/.d')
self.assertRaises(ValueError, P('a/b').with_suffix, './.d') self.assertRaises(ValueError, P('a/b').with_suffix, './.d')
self.assertRaises(ValueError, P('a/b').with_suffix, '.d/.') self.assertRaises(ValueError, P('a/b').with_suffix, '.d/.')
self.assertRaises(ValueError, P('a/b').with_suffix,
(self.flavour.sep, 'd'))
def test_relative_to_common(self): def test_relative_to_common(self):
P = self.cls P = self.cls

2
Misc/NEWS.d/next/Library/2018-08-04-00-06-28.bpo-34333.5NHG93.rst Normal file
View file

@ -0,0 +1,2 @@
Fix %-formatting in :meth:`pathlib.PurePath.with_suffix` when formatting an
error message.