mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-10-09 16:34:44 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 17

Issue #13070: Fix a crash when a TextIOWrapper caught in a reference cycle

Browse source 
would be finalized after the reference to its underlying BufferedRWPair's
writer got cleared by the GC.
This commit is contained in:
Charles-François Natali 2011-10-05 19:53:43 +02:00
parent 1b7da519b0
commit 42c28cdd1d
3 changed files with 24 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

15
Lib/test/test_io.py
View file

@ -2414,6 +2414,21 @@ class CTextIOWrapperTest(TextIOWrapperTest):
with self.open(support.TESTFN, "rb") as f:
self.assertEqual(f.read(), b"456def")
def test_rwpair_cleared_before_textio(self):
# Issue 13070: TextIOWrapper's finalization would crash when called
# after the reference to the underlying BufferedRWPair's writer got
# cleared by the GC.
for i in range(1000):
b1 = self.BufferedRWPair(self.MockRawIO(), self.MockRawIO())
t1 = self.TextIOWrapper(b1, encoding="ascii")
b2 = self.BufferedRWPair(self.MockRawIO(), self.MockRawIO())
t2 = self.TextIOWrapper(b2, encoding="ascii")
# circular references
t1.buddy = t2
t2.buddy = t1
support.gc_collect()
class PyTextIOWrapperTest(TextIOWrapperTest):
pass