mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-28 20:56:54 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

gh-120544: Add else: fail() to tests where exception is expected (#120545)

Browse source
This commit is contained in:
Nikita Sobolev 2024-06-15 13:33:14 +03:00 • committed by GitHub
parent d4039d3f6f
commit 42ebdd83bb
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 12 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Lib/test/test_exceptions.py
View file

@ -1859,6 +1859,8 @@ class NameErrorTests(unittest.TestCase):
except self.failureException: except self.failureException:
with support.captured_stderr() as err: with support.captured_stderr() as err:
sys.__excepthook__(*sys.exc_info()) sys.__excepthook__(*sys.exc_info())
else:
self.fail("assertRaisesRegex should have failed.")
self.assertIn("aab", err.getvalue()) self.assertIn("aab", err.getvalue())

10
Lib/test/test_unittest/test_case.py
View file

@ -1151,6 +1151,8 @@ test case
# need to remove the first line of the error message # need to remove the first line of the error message
error = str(e).split('\n', 1)[1] error = str(e).split('\n', 1)[1]
self.assertEqual(sample_text_error, error) self.assertEqual(sample_text_error, error)
else:
self.fail(f'{self.failureException} not raised')
def testAssertEqualSingleLine(self): def testAssertEqualSingleLine(self):
sample_text = "laden swallows fly slowly" sample_text = "laden swallows fly slowly"
@ -1167,6 +1169,8 @@ test case
# need to remove the first line of the error message # need to remove the first line of the error message
error = str(e).split('\n', 1)[1] error = str(e).split('\n', 1)[1]
self.assertEqual(sample_text_error, error) self.assertEqual(sample_text_error, error)
else:
self.fail(f'{self.failureException} not raised')
def testAssertEqualwithEmptyString(self): def testAssertEqualwithEmptyString(self):
'''Verify when there is an empty string involved, the diff output '''Verify when there is an empty string involved, the diff output
@ -1184,6 +1188,8 @@ test case
# need to remove the first line of the error message # need to remove the first line of the error message
error = str(e).split('\n', 1)[1] error = str(e).split('\n', 1)[1]
self.assertEqual(sample_text_error, error) self.assertEqual(sample_text_error, error)
else:
self.fail(f'{self.failureException} not raised')
def testAssertEqualMultipleLinesMissingNewlineTerminator(self): def testAssertEqualMultipleLinesMissingNewlineTerminator(self):
'''Verifying format of diff output from assertEqual involving strings '''Verifying format of diff output from assertEqual involving strings
@ -1204,6 +1210,8 @@ test case
# need to remove the first line of the error message # need to remove the first line of the error message
error = str(e).split('\n', 1)[1] error = str(e).split('\n', 1)[1]
self.assertEqual(sample_text_error, error) self.assertEqual(sample_text_error, error)
else:
self.fail(f'{self.failureException} not raised')
def testAssertEqualMultipleLinesMismatchedNewlinesTerminators(self): def testAssertEqualMultipleLinesMismatchedNewlinesTerminators(self):
'''Verifying format of diff output from assertEqual involving strings '''Verifying format of diff output from assertEqual involving strings
@ -1227,6 +1235,8 @@ test case
# need to remove the first line of the error message # need to remove the first line of the error message
error = str(e).split('\n', 1)[1] error = str(e).split('\n', 1)[1]
self.assertEqual(sample_text_error, error) self.assertEqual(sample_text_error, error)
else:
self.fail(f'{self.failureException} not raised')
def testEqualityBytesWarning(self): def testEqualityBytesWarning(self):
if sys.flags.bytes_warning: if sys.flags.bytes_warning: