bpo-45061: Detect Py_DECREF(Py_True) bug (GH-28089)

Add a deallocator to the bool type to detect refcount bugs in C
extensions which call Py_DECREF(Py_True) or Py_DECREF(Py_False) by
mistake.
This commit is contained in:
Victor Stinner 2021-08-31 18:05:15 +02:00 committed by GitHub
parent 9a7ec2fcde
commit 4300352000
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 14 additions and 7 deletions

View file

@ -153,6 +153,13 @@ static PyNumberMethods bool_as_number = {
0, /* nb_index */
};
static void _Py_NO_RETURN
bool_dealloc(PyObject* Py_UNUSED(ignore))
{
Py_FatalError("deallocating True or False likely caused by "
"a refcount bug in a C extension");
}
/* The type object for bool. Note that this cannot be subclassed! */
PyTypeObject PyBool_Type = {
@ -160,7 +167,7 @@ PyTypeObject PyBool_Type = {
"bool",
sizeof(struct _longobject),
0,
0, /* tp_dealloc */
bool_dealloc, /* tp_dealloc */
0, /* tp_vectorcall_offset */
0, /* tp_getattr */
0, /* tp_setattr */