mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-09-27 10:50:04 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 13

bpo-45061: Detect Py_DECREF(Py_True) bug (GH-28089)

Browse source 
Add a deallocator to the bool type to detect refcount bugs in C
extensions which call Py_DECREF(Py_True) or Py_DECREF(Py_False) by
mistake.
This commit is contained in:
Victor Stinner 2021-08-31 18:05:15 +02:00 • committed by GitHub
parent 9a7ec2fcde
commit 4300352000
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 14 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Misc/NEWS.d/next/C API/2021-08-31-15-21-36.bpo-45061.ZH0HVe.rst Normal file
View file

@ -0,0 +1,3 @@
Add a deallocator to the :class:`bool` type to detect refcount bugs in C
extensions which call ``Py_DECREF(Py_True);`` or ``Py_DECREF(Py_False);`` by
mistake. Patch by Victor Stinner.

9
Objects/boolobject.c
View file

@ -153,6 +153,13 @@ static PyNumberMethods bool_as_number = {
0, /* nb_index */ 0, /* nb_index */
}; };
static void _Py_NO_RETURN
bool_dealloc(PyObject* Py_UNUSED(ignore))
{
Py_FatalError("deallocating True or False likely caused by "
"a refcount bug in a C extension");
}
/* The type object for bool. Note that this cannot be subclassed! */ /* The type object for bool. Note that this cannot be subclassed! */
PyTypeObject PyBool_Type = { PyTypeObject PyBool_Type = {
@ -160,7 +167,7 @@ PyTypeObject PyBool_Type = {
"bool", "bool",
sizeof(struct _longobject), sizeof(struct _longobject),
0, 0,
0, /* tp_dealloc */ bool_dealloc, /* tp_dealloc */
0, /* tp_vectorcall_offset */ 0, /* tp_vectorcall_offset */
0, /* tp_getattr */ 0, /* tp_getattr */
0, /* tp_setattr */ 0, /* tp_setattr */

9
Objects/object.c
View file

@ -1560,14 +1560,11 @@ none_repr(PyObject *op)
return PyUnicode_FromString("None"); return PyUnicode_FromString("None");
} }
/* ARGUSED */
static void _Py_NO_RETURN static void _Py_NO_RETURN
none_dealloc(PyObject* ignore) none_dealloc(PyObject* Py_UNUSED(ignore))
{ {
/* This should never get called, but we also don't want to SEGV if Py_FatalError("deallocating None likely caused by a refcount bug "
* we accidentally decref None out of existence. "in a C extension");
*/
Py_FatalError("deallocating None");
} }
static PyObject * static PyObject *