mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-09-20 15:40:32 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Issue #18174: Explain why is_valid_fd() uses dup() instead of fstat()

Browse source
This commit is contained in:
Victor Stinner 2015-09-29 13:59:50 +02:00
parent 3f7468507a
commit 449b271799
1 changed files with 3 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Python/pylifecycle.c
View file

@ -972,6 +972,9 @@ is_valid_fd(int fd)
if (fd < 0 || !_PyVerify_fd(fd)) if (fd < 0 || !_PyVerify_fd(fd))
return 0; return 0;
_Py_BEGIN_SUPPRESS_IPH _Py_BEGIN_SUPPRESS_IPH
/* Prefer dup() over fstat(). fstat() can require input/output whereas
dup() doesn't, there is a low risk of EMFILE/ENFILE at Python
startup. */
fd2 = dup(fd); fd2 = dup(fd);
if (fd2 >= 0) if (fd2 >= 0)
close(fd2); close(fd2);