From 44fe32061d60f4bd9c4fa48c24e3e4ba26033dba Mon Sep 17 00:00:00 2001 From: Neil Schemenauer Date: Sun, 21 Feb 2021 15:24:41 -0800 Subject: [PATCH] [3.9] bpo-43288: Fix bug in test_importlib test. (GH-24616) * bpo-43288: Fix bug in test_importlib test. (GH-24612) * Fix failed merge of bpo-43288. (GH-24614) --- Lib/test/test_importlib/fixtures.py | 4 ++++ .../next/Tests/2021-02-21-11-11-53.bpo-43288.LfTvL-.rst | 2 ++ 2 files changed, 6 insertions(+) create mode 100644 Misc/NEWS.d/next/Tests/2021-02-21-11-11-53.bpo-43288.LfTvL-.rst diff --git a/Lib/test/test_importlib/fixtures.py b/Lib/test/test_importlib/fixtures.py index 2e55d14b9aa..d71f2644066 100644 --- a/Lib/test/test_importlib/fixtures.py +++ b/Lib/test/test_importlib/fixtures.py @@ -5,6 +5,7 @@ import pathlib import tempfile import textwrap import contextlib +import unittest @contextlib.contextmanager @@ -220,6 +221,9 @@ class FileBuilder: return test.support.FS_NONASCII or \ self.skip("File system does not support non-ascii.") + def skip(self, reason): + raise unittest.SkipTest(reason) + def DALS(str): "Dedent and left-strip" diff --git a/Misc/NEWS.d/next/Tests/2021-02-21-11-11-53.bpo-43288.LfTvL-.rst b/Misc/NEWS.d/next/Tests/2021-02-21-11-11-53.bpo-43288.LfTvL-.rst new file mode 100644 index 00000000000..8463540ae8a --- /dev/null +++ b/Misc/NEWS.d/next/Tests/2021-02-21-11-11-53.bpo-43288.LfTvL-.rst @@ -0,0 +1,2 @@ +Fix test_importlib to correctly skip Unicode file tests if the fileystem +does not support them.