mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-03 08:34:29 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

bpo-32905: IDLE - remove unused code in pyparse module (GH-5807)

Browse source 
dump is similar to print but less flexible.  lastopenbracketpos is now always initialized in _study2, as was stmt_bracketing, so the class settings are not needed.  get_last_open_bracket_pos is never called.
This commit is contained in:
Terry Jan Reedy 2018-02-22 01:19:02 -05:00 • committed by GitHub
parent 745dc65b17
commit 451d1edaf4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 50 deletions
Download patch file Download diff file Expand all files Collapse all files

34
Lib/idlelib/idle_test/test_pyparse.py
View file

@ -1,4 +1,7 @@
"""Unittest for idlelib.pyparse.py."""
"""Unittest for idlelib.pyparse.py.
Coverage: 97%
"""
from collections import namedtuple
import unittest
@ -272,8 +275,6 @@ class PyParseTest(unittest.TestCase):
)
for test in tests:
# There is a bug where this is carried forward from last item.
p.lastopenbracketpos = None
with self.subTest(string=test.string):
setstr(test.string)
study()
@ -464,33 +465,6 @@ class PyParseTest(unittest.TestCase):
setstr(test.string)
test.assert_(closer())
def test_get_last_open_bracket_pos(self):
eq = self.assertEqual
p = self.parser
setstr = p.set_str
openbracket = p.get_last_open_bracket_pos
TestInfo = namedtuple('TestInfo', ['string', 'position'])
tests = (
TestInfo('', None),
TestInfo('a\n', None),
TestInfo('# (\n', None),
TestInfo('""" (\n', None),
TestInfo('a = (1 + 2) - 5 *\\\n', None),
TestInfo('\n def function1(self, a,\n', 17),
TestInfo('\n def function1(self, a, # End of line comment.\n', 17),
TestInfo('{)(]\n', None),
TestInfo('(((((((((()))))))\n', 2),
TestInfo('(((((((((())\n)))\n))\n', 2),
)
for test in tests:
# There is a bug where the value is carried forward from last item.
p.lastopenbracketpos = None
with self.subTest(string=test.string):
setstr(test.string)
eq(openbracket(), test.position)
def test_get_last_stmt_bracketing(self):
eq = self.assertEqual
p = self.parser