mirror of
https://github.com/python/cpython.git
synced 2025-08-04 17:08:35 +00:00
gh-113538: Don't error in stream reader protocol callback when task is cancelled (#113690)
This commit is contained in:
parent
1600d78e2d
commit
4681a5271a
3 changed files with 21 additions and 7 deletions
|
@ -246,6 +246,9 @@ class StreamReaderProtocol(FlowControlMixin, protocols.Protocol):
|
|||
self._stream_writer)
|
||||
if coroutines.iscoroutine(res):
|
||||
def callback(task):
|
||||
if task.cancelled():
|
||||
transport.close()
|
||||
return
|
||||
exc = task.exception()
|
||||
if exc is not None:
|
||||
self._loop.call_exception_handler({
|
||||
|
|
|
@ -1129,7 +1129,7 @@ os.close(fd)
|
|||
|
||||
self.assertEqual(messages, [])
|
||||
|
||||
def test_unhandled_exceptions(self) -> None:
|
||||
def _basetest_unhandled_exceptions(self, handle_echo):
|
||||
port = socket_helper.find_unused_port()
|
||||
|
||||
messages = []
|
||||
|
@ -1143,9 +1143,6 @@ os.close(fd)
|
|||
await wr.wait_closed()
|
||||
|
||||
async def main():
|
||||
async def handle_echo(reader, writer):
|
||||
raise Exception('test')
|
||||
|
||||
server = await asyncio.start_server(
|
||||
handle_echo, 'localhost', port)
|
||||
await server.start_serving()
|
||||
|
@ -1154,11 +1151,20 @@ os.close(fd)
|
|||
await server.wait_closed()
|
||||
|
||||
self.loop.run_until_complete(main())
|
||||
return messages
|
||||
|
||||
def test_unhandled_exception(self):
|
||||
async def handle_echo(reader, writer):
|
||||
raise Exception('test')
|
||||
messages = self._basetest_unhandled_exceptions(handle_echo)
|
||||
self.assertEqual(messages[0]['message'],
|
||||
'Unhandled exception in client_connected_cb')
|
||||
# Break explicitly reference cycle
|
||||
messages = None
|
||||
'Unhandled exception in client_connected_cb')
|
||||
|
||||
def test_unhandled_cancel(self):
|
||||
async def handle_echo(reader, writer):
|
||||
asyncio.current_task().cancel()
|
||||
messages = self._basetest_unhandled_exceptions(handle_echo)
|
||||
self.assertEqual(messages, [])
|
||||
|
||||
|
||||
if __name__ == '__main__':
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue