mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-03 16:39:00 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

[3.13] gh-122431: Disallow negative values in readline.append_history_file (GH-122469) (#127641)

Browse source 
gh-122431: Disallow negative values in `readline.append_history_file` (GH-122469)
(cherry picked from commit 208b0fb645)

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
This commit is contained in:
Miss Islington (bot) 2024-12-05 18:15:44 +01:00 • committed by GitHub
parent 3e11b5c2ba
commit 468e8dad7e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 15 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Lib/test/test_readline.py
View file

@ -114,6 +114,14 @@ class TestHistoryManipulation (unittest.TestCase):
# write_history_file can create the target
readline.write_history_file(hfilename)
# Negative values should be disallowed
with self.assertRaises(ValueError):
readline.append_history_file(-42, hfilename)
# See gh-122431, using the minimum signed integer value caused a segfault
with self.assertRaises(ValueError):
readline.append_history_file(-2147483648, hfilename)
def test_nonascii_history(self):
readline.clear_history()
try: