mirror of
https://github.com/python/cpython.git
synced 2025-08-31 05:58:33 +00:00
bpo-39142: Avoid converting namedtuple instances to ConvertingTuple. (GH-17773)
This uses the heuristic of assuming a named tuple is a subclass of tuple with a _fields attribute. This change means that contents of a named tuple wouldn't be converted - if a user wants to have ConvertingTuple functionality from a namedtuple, they will have to implement it themselves.
This commit is contained in:
parent
22424c02e5
commit
46abfc1416
3 changed files with 37 additions and 1 deletions
|
@ -3379,6 +3379,37 @@ class ConfigDictTest(BaseTest):
|
|||
self.assertRaises(ValueError, bc.convert, 'cfg://!')
|
||||
self.assertRaises(KeyError, bc.convert, 'cfg://adict[2]')
|
||||
|
||||
def test_namedtuple(self):
|
||||
# see bpo-39142
|
||||
from collections import namedtuple
|
||||
|
||||
class MyHandler(logging.StreamHandler):
|
||||
def __init__(self, resource, *args, **kwargs):
|
||||
super().__init__(*args, **kwargs)
|
||||
self.resource: namedtuple = resource
|
||||
|
||||
def emit(self, record):
|
||||
record.msg += f' {self.resource.type}'
|
||||
return super().emit(record)
|
||||
|
||||
Resource = namedtuple('Resource', ['type', 'labels'])
|
||||
resource = Resource(type='my_type', labels=['a'])
|
||||
|
||||
config = {
|
||||
'version': 1,
|
||||
'handlers': {
|
||||
'myhandler': {
|
||||
'()': MyHandler,
|
||||
'resource': resource
|
||||
}
|
||||
},
|
||||
'root': {'level': 'INFO', 'handlers': ['myhandler']},
|
||||
}
|
||||
with support.captured_stderr() as stderr:
|
||||
self.apply_config(config)
|
||||
logging.info('some log')
|
||||
self.assertEqual(stderr.getvalue(), 'some log my_type\n')
|
||||
|
||||
class ManagerTest(BaseTest):
|
||||
def test_manager_loggerclass(self):
|
||||
logged = []
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue