mirror of
https://github.com/python/cpython.git
synced 2025-08-25 11:15:02 +00:00
random.gauss() uses a piece of hidden state used by nothing else,
and the .seed() and .whseed() methods failed to reset it. In other words, setting the seed didn't completely determine the sequence of results produced by random.gauss(). It does now. Programs repeatedly mixing calls to a seed method with calls to gauss() may see different results now. Bugfix candidate (random.gauss() has always been broken in this way), despite that it may change results.
This commit is contained in:
parent
2b41b0d6a7
commit
46c04e140c
3 changed files with 30 additions and 1 deletions
|
@ -116,7 +116,6 @@ class Random:
|
|||
"""
|
||||
|
||||
self.seed(x)
|
||||
self.gauss_next = None
|
||||
|
||||
## -------------------- core generator -------------------
|
||||
|
||||
|
@ -150,6 +149,8 @@ class Random:
|
|||
a, z = divmod(a, 30322)
|
||||
self._seed = int(x)+1, int(y)+1, int(z)+1
|
||||
|
||||
self.gauss_next = None
|
||||
|
||||
def random(self):
|
||||
"""Get the next random number in the range [0.0, 1.0)."""
|
||||
|
||||
|
@ -238,6 +239,8 @@ class Random:
|
|||
# Zero is a poor seed, so substitute 1
|
||||
self._seed = (x or 1, y or 1, z or 1)
|
||||
|
||||
self.gauss_next = None
|
||||
|
||||
def whseed(self, a=None):
|
||||
"""Seed from hashable object's hash code.
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue