mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-04 00:48:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Revert "gh-87079: Warn on unintended signal wakeup fd override in asyncio (#96807)" (#96898)

Browse source 
This reverts commit 0587810698.
Reason: This broke buildbots (some warnings added by that commit are turned to errors in the SSL buildbot).
Repro:  ./python Lib/test/ssltests.py
This commit is contained in:
Guido van Rossum 2022-09-17 14:12:45 -07:00 • committed by GitHub
parent 7e36abbb78
commit 487135a396
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 8 additions and 66 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Lib/asyncio/proactor_events.py
View file

@ -635,12 +635,7 @@ class BaseProactorEventLoop(base_events.BaseEventLoop):
self._make_self_pipe()
if threading.current_thread() is threading.main_thread():
# wakeup fd can only be installed to a file descriptor from the main thread
oldfd = signal.set_wakeup_fd(self._csock.fileno())
if oldfd != -1:
warnings.warn(
"Signal wakeup fd was already set",
ResourceWarning,
source=self)
signal.set_wakeup_fd(self._csock.fileno())
def _make_socket_transport(self, sock, protocol, waiter=None,
extra=None, server=None):
@ -689,12 +684,7 @@ class BaseProactorEventLoop(base_events.BaseEventLoop):
return
if threading.current_thread() is threading.main_thread():
oldfd = signal.set_wakeup_fd(-1)
if oldfd != self._csock.fileno():
warnings.warn(
"Got unexpected signal wakeup fd",
ResourceWarning,
source=self)
signal.set_wakeup_fd(-1)
# Call these methods before closing the event loop (before calling
# BaseEventLoop.close), because they can schedule callbacks with
# call_soon(), which is forbidden when the event loop is closed.