mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-31 05:58:33 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

Fix some comments in ceval.c and fix lltrace output (#101297)

Browse source 
The comment at the top was rather outdated. :-)

Also added a note about the dangers of dump_stack().
This commit is contained in:
Guido van Rossum 2023-01-24 14:58:18 -08:00 • committed by GitHub
parent 1a9d8c750b
commit 498598e8c2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Python/ceval.c
View file

@ -1,10 +1,5 @@
/* Execute compiled code */ /* Execute compiled code */
/* XXX TO DO:
XXX speed up searching for keywords by using a dictionary
XXX document it!
*/
#define _PY_INTERPRETER #define _PY_INTERPRETER
#include "Python.h" #include "Python.h"
@ -133,6 +128,9 @@ lltrace_instruction(_PyInterpreterFrame *frame,
PyObject **stack_pointer, PyObject **stack_pointer,
_Py_CODEUNIT *next_instr) _Py_CODEUNIT *next_instr)
{ {
/* This dump_stack() operation is risky, since the repr() of some
objects enters the interpreter recursively. It is also slow.
So you might want to comment it out. */
dump_stack(frame, stack_pointer); dump_stack(frame, stack_pointer);
int oparg = _Py_OPARG(*next_instr); int oparg = _Py_OPARG(*next_instr);
int opcode = _Py_OPCODE(*next_instr); int opcode = _Py_OPCODE(*next_instr);
@ -155,7 +153,7 @@ lltrace_resume_frame(_PyInterpreterFrame *frame)
fobj == NULL || fobj == NULL ||
!PyFunction_Check(fobj) !PyFunction_Check(fobj)
) { ) {
printf("\nResuming frame."); printf("\nResuming frame.\n");
return; return;
} }
PyFunctionObject *f = (PyFunctionObject *)fobj; PyFunctionObject *f = (PyFunctionObject *)fobj;