Fix some comments in ceval.c and fix lltrace output (#101297)

The comment at the top was rather outdated. :-)

Also added a note about the dangers of dump_stack().
This commit is contained in:
Guido van Rossum 2023-01-24 14:58:18 -08:00 committed by GitHub
parent 1a9d8c750b
commit 498598e8c2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -1,10 +1,5 @@
/* Execute compiled code */
/* XXX TO DO:
XXX speed up searching for keywords by using a dictionary
XXX document it!
*/
#define _PY_INTERPRETER
#include "Python.h"
@ -133,6 +128,9 @@ lltrace_instruction(_PyInterpreterFrame *frame,
PyObject **stack_pointer,
_Py_CODEUNIT *next_instr)
{
/* This dump_stack() operation is risky, since the repr() of some
objects enters the interpreter recursively. It is also slow.
So you might want to comment it out. */
dump_stack(frame, stack_pointer);
int oparg = _Py_OPARG(*next_instr);
int opcode = _Py_OPCODE(*next_instr);
@ -155,7 +153,7 @@ lltrace_resume_frame(_PyInterpreterFrame *frame)
fobj == NULL ||
!PyFunction_Check(fobj)
) {
printf("\nResuming frame.");
printf("\nResuming frame.\n");
return;
}
PyFunctionObject *f = (PyFunctionObject *)fobj;