keep the slice.step field as NULL if no step expression is given

This commit is contained in:
Benjamin Peterson 2009-06-13 01:40:00 +00:00
parent cb73bdac95
commit 4afbba3d34
3 changed files with 10 additions and 8 deletions

View file

@ -146,6 +146,12 @@ class AST_Tests(unittest.TestCase):
self.assertEquals(to_tuple(ast_tree), o)
self._assert_order(ast_tree, (0, 0))
def test_slice(self):
slc = ast.parse("x[::]").body[0].value.slice
self.assertIsNone(slc.upper)
self.assertIsNone(slc.lower)
self.assertIsNone(slc.step)
def test_nodeclasses(self):
x = ast.BinOp(1, 2, 3, lineno=0)
self.assertEquals(x.left, 1)

View file

@ -12,6 +12,9 @@ What's New in Python 2.7 alpha 1
Core and Builtins
-----------------
- In the slice AST type, the step field will always be None if a step expression
is not specified.
- Issue #4547: When debugging a very large function, it was not always
possible to update the lineno attribute of the current frame.

View file

@ -1468,14 +1468,7 @@ ast_for_slice(struct compiling *c, const node *n)
ch = CHILD(n, NCH(n) - 1);
if (TYPE(ch) == sliceop) {
if (NCH(ch) == 1) {
/* No expression, so step is None */
ch = CHILD(ch, 0);
step = Name(new_identifier("None", c->c_arena), Load,
LINENO(ch), ch->n_col_offset, c->c_arena);
if (!step)
return NULL;
} else {
if (NCH(ch) != 1) {
ch = CHILD(ch, 1);
if (TYPE(ch) == test) {
step = ast_for_expr(c, ch);