mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-11-20 02:50:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

Add proper tests for closed files to various I/O operations,

Browse source 
restoring a disabled test.
This was necessary to make test_pickle.py pass.
This commit is contained in:
Guido van Rossum 2007-07-10 09:12:49 +00:00
parent 2b6a97e69c
commit 4b5386f398
2 changed files with 41 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

30
Lib/test/test_file.py
View file

@ -89,21 +89,31 @@ class AutoFileTests(unittest.TestCase):
self.assert_(f.closed)
def testMethods(self):
methods = ['fileno', 'flush', 'isatty', '__next__', 'read', 'readinto',
'readline', 'readlines', 'seek', 'tell', 'truncate',
'write', '__iter__']
if sys.platform.startswith('atheos'):
methods.remove('truncate')
methods = [('fileno', ()),
('flush', ()),
('isatty', ()),
('__next__', ()),
('read', ()),
('write', (b"",)),
('readline', ()),
('readlines', ()),
('seek', (0,)),
('tell', ()),
('write', (b"",)),
('writelines', ([],)),
('__iter__', ()),
]
if not sys.platform.startswith('atheos'):
methods.append(('truncate', ()))
# __exit__ should close the file
self.f.__exit__(None, None, None)
self.assert_(self.f.closed)
## for methodname in methods:
## method = getattr(self.f, methodname)
## # should raise on closed file
## self.assertRaises(ValueError, method)
## self.assertRaises(ValueError, self.f.writelines, [])
for methodname, args in methods:
method = getattr(self.f, methodname)
# should raise on closed file
self.assertRaises(ValueError, method, *args)
# file is closed, __exit__ shouldn't do anything
self.assertEquals(self.f.__exit__(None, None, None), None)