mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-11-24 20:30:18 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

Remove calls to currentThread() in _Condition methods that were side-effect.

Browse source 
Side-effects were deemed unnecessary and were causing problems at shutdown
time when threads were catching exceptions at start time and then triggering
exceptions trying to call currentThread() after gc'ed.  Masked the initial
exception which was deemed bad.

Fixes bug #754449 .
This commit is contained in:
Brett Cannon 2004-03-08 22:18:57 +00:00
parent 3fd500b4a5
commit 4b6b7f1515
1 changed files with 0 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Lib/threading.py
View file

@ -193,7 +193,6 @@ class _Condition(_Verbose):
return True
def wait(self, timeout=None):
currentThread() # for side-effect
assert self._is_owned(), "wait() of un-acquire()d lock"
waiter = _allocate_lock()
waiter.acquire()
@ -235,7 +234,6 @@ class _Condition(_Verbose):
self._acquire_restore(saved_state)
def notify(self, n=1):
currentThread() # for side-effect
assert self._is_owned(), "notify() of un-acquire()d lock"
__waiters = self.__waiters
waiters = __waiters[:n]