mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-07-24 03:35:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

* Increase test coverage.

Browse source 
* Have groupby() be careful about decreffing structure members.
This commit is contained in:
Raymond Hettinger 2004-09-28 04:45:28 +00:00
parent aec3c9b54f
commit 4cda01e260
2 changed files with 38 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Modules/itertoolsmodule.c
View file

@ -75,7 +75,7 @@ groupby_traverse(groupbyobject *gbo, visitproc visit, void *arg)
static PyObject *
groupby_next(groupbyobject *gbo)
{
PyObject *newvalue, *newkey, *r, *grouper;
PyObject *newvalue, *newkey, *r, *grouper, *tmp;
/* skip to next iteration group */
for (;;) {
@ -110,15 +110,19 @@ groupby_next(groupbyobject *gbo)
}
}
Py_XDECREF(gbo->currkey);
tmp = gbo->currkey;
gbo->currkey = newkey;
Py_XDECREF(gbo->currvalue);
Py_XDECREF(tmp);
tmp = gbo->currvalue;
gbo->currvalue = newvalue;
Py_XDECREF(tmp);
}
Py_XDECREF(gbo->tgtkey);
gbo->tgtkey = gbo->currkey;
Py_INCREF(gbo->currkey);
tmp = gbo->tgtkey;
gbo->tgtkey = gbo->currkey;
Py_XDECREF(tmp);
grouper = _grouper_create(gbo, gbo->tgtkey);
if (grouper == NULL)