mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-09-30 12:21:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

Issue #9651: Fix a crash when ctypes.create_string_buffer(0) was passed to

Browse source 
some functions like file.write().
This commit is contained in:
Amaury Forgeot d'Arc 2011-08-30 21:40:20 +02:00
parent 97d67924e3
commit 4cfb42dd2d
3 changed files with 11 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Lib/ctypes/test/test_buffers.py
View file

@ -20,6 +20,10 @@ class StringBufferTestCase(unittest.TestCase):
self.assertEqual(b[::2], b"ac") self.assertEqual(b[::2], b"ac")
self.assertEqual(b[::5], b"a") self.assertEqual(b[::5], b"a")
def test_buffer_interface(self):
self.assertEqual(len(bytearray(create_string_buffer(0))), 0)
self.assertEqual(len(bytearray(create_string_buffer(1))), 1)
try: try:
c_wchar c_wchar
except NameError: except NameError:

3
Misc/NEWS
View file

@ -152,6 +152,9 @@ Library
Extension Modules Extension Modules
----------------- -----------------
- Issue #9651: Fix a crash when ctypes.create_string_buffer(0) was passed to
some functions like file.write().
- Issue #10309: Define _GNU_SOURCE so that mremap() gets the proper - Issue #10309: Define _GNU_SOURCE so that mremap() gets the proper
signature. Without this, architectures where sizeof void* != sizeof int are signature. Without this, architectures where sizeof void* != sizeof int are
broken. Patch given by Hallvard B Furuseth. broken. Patch given by Hallvard B Furuseth.

2
Modules/_ctypes/_ctypes.c
View file

@ -2488,9 +2488,11 @@ static int PyCData_NewGetBuffer(PyObject *_self, Py_buffer *view, int flags)
view->ndim = dict->ndim; view->ndim = dict->ndim;
view->shape = dict->shape; view->shape = dict->shape;
view->itemsize = self->b_size; view->itemsize = self->b_size;
if (view->itemsize) {
for (i = 0; i < view->ndim; ++i) { for (i = 0; i < view->ndim; ++i) {
view->itemsize /= dict->shape[i]; view->itemsize /= dict->shape[i];
} }
}
view->strides = NULL; view->strides = NULL;
view->suboffsets = NULL; view->suboffsets = NULL;
view->internal = NULL; view->internal = NULL;