mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-09-27 10:50:04 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 13

gh-96021: Explicitly close the IsolatedAsyncioTestCase runner in tests (GH-96135)

Browse source 
Tests for IsolatedAsyncioTestCase.debug() rely on the runner be closed
in __del__. It makes tests depending on the GC an unreliable on other
implementations. It is better to close the runner explicitly even if
currently there is no a public API for this.
This commit is contained in:
Serhiy Storchaka 2022-08-24 15:07:20 +03:00 • committed by GitHub
parent 420f39f457
commit 4de06e3cc0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Lib/test/test_unittest/test_async_case.py
View file

@ -43,10 +43,10 @@ VAR = contextvars.ContextVar('VAR', default=())
class TestAsyncCase(unittest.TestCase): class TestAsyncCase(unittest.TestCase):
maxDiff = None maxDiff = None
def tearDown(self): def setUp(self):
# Ensure that IsolatedAsyncioTestCase instances are destroyed before # Ensure that IsolatedAsyncioTestCase instances are destroyed before
# starting a new event loop # starting a new event loop
support.gc_collect() self.addCleanup(support.gc_collect)
def test_full_cycle(self): def test_full_cycle(self):
class Test(unittest.IsolatedAsyncioTestCase): class Test(unittest.IsolatedAsyncioTestCase):
@ -151,6 +151,7 @@ class TestAsyncCase(unittest.TestCase):
events = [] events = []
test = Test("test_func") test = Test("test_func")
self.addCleanup(test._tearDownAsyncioRunner)
try: try:
test.debug() test.debug()
except MyException: except MyException:
@ -186,6 +187,7 @@ class TestAsyncCase(unittest.TestCase):
events = [] events = []
test = Test("test_func") test = Test("test_func")
self.addCleanup(test._tearDownAsyncioRunner)
try: try:
test.debug() test.debug()
except MyException: except MyException:
@ -221,6 +223,7 @@ class TestAsyncCase(unittest.TestCase):
events = [] events = []
test = Test("test_func") test = Test("test_func")
self.addCleanup(test._tearDownAsyncioRunner)
try: try:
test.debug() test.debug()
except MyException: except MyException:
@ -262,6 +265,7 @@ class TestAsyncCase(unittest.TestCase):
events = [] events = []
test = Test("test_func") test = Test("test_func")
self.addCleanup(test._tearDownAsyncioRunner)
try: try:
test.debug() test.debug()
except MyException: except MyException:
@ -424,6 +428,7 @@ class TestAsyncCase(unittest.TestCase):
events = [] events = []
test = Test("test_func") test = Test("test_func")
self.addCleanup(test._tearDownAsyncioRunner)
try: try:
test.debug() test.debug()
except MyException: except MyException: