mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-09-26 18:29:57 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

Issue #18560: Fix potential NULL pointer dereference in sum()

Browse source
This commit is contained in:
Christian Heimes 2013-07-26 22:50:01 +02:00
commit 4ebf6d7c3c
2 changed files with 7 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Misc/NEWS
View file

@ -10,6 +10,8 @@ What's New in Python 3.4.0 Alpha 1?
Core and Builtins Core and Builtins
----------------- -----------------
- Issue #18560: Fix potential NULL pointer dereference in sum().
- Issue #18520: Add a new PyStructSequence_InitType2() function, same than - Issue #18520: Add a new PyStructSequence_InitType2() function, same than
PyStructSequence_InitType() except that it has a return value (0 on success, PyStructSequence_InitType() except that it has a return value (0 on success,
-1 on error). -1 on error).

5
Python/bltinmodule.c
View file

@ -2030,6 +2030,11 @@ builtin_sum(PyObject *self, PyObject *args)
} }
/* Either overflowed or is not an int. Restore real objects and process normally */ /* Either overflowed or is not an int. Restore real objects and process normally */
result = PyLong_FromLong(i_result); result = PyLong_FromLong(i_result);
if (result == NULL) {
Py_DECREF(item);
Py_DECREF(iter);
return NULL;
}
temp = PyNumber_Add(result, item); temp = PyNumber_Add(result, item);
Py_DECREF(result); Py_DECREF(result);
Py_DECREF(item); Py_DECREF(item);