Issue #18279: Add tests for idlelib/RstripExtension.py. Original patch by

Phil Webster. With that available, modify RstripExtension.py to stop deleting
null slices, which caused a file to be marked as changed when it was not.
This commit is contained in:
Terry Jan Reedy 2013-07-13 02:34:43 -04:00
parent 037f65841c
commit 4f133e2e98
5 changed files with 94 additions and 8 deletions

View file

@ -1,13 +1,9 @@
'Provides "Strip trailing whitespace" under the "Format" menu.'
__author__ = "Roger D. Serwy <roger.serwy at gmail.com>"
class RstripExtension:
menudefs = [
('format', [None,
('Strip trailing whitespace', '<<do-rstrip>>'),
]),]
('format', [None, ('Strip trailing whitespace', '<<do-rstrip>>'), ] ), ]
def __init__(self, editwin):
self.editwin = editwin
@ -20,10 +16,18 @@ class RstripExtension:
undo.undo_block_start()
end_line = int(float(text.index('end'))) + 1
end_line = int(float(text.index('end')))
for cur in range(1, end_line):
txt = text.get('%i.0' % cur, '%i.0 lineend' % cur)
txt = text.get('%i.0' % cur, '%i.end' % cur)
raw = len(txt)
cut = len(txt.rstrip())
text.delete('%i.%i' % (cur, cut), '%i.0 lineend' % cur)
# Since text.delete() marks file as changed, even if not,
# only call it when needed to actually delete something.
if cut < raw:
text.delete('%i.%i' % (cur, cut), '%i.end' % cur)
undo.undo_block_stop()
if __name__ == "__main__":
import unittest
unittest.main('idlelib.idle_test.test_rstrip', verbosity=2, exit=False)