[3.12] gh-106931: Intern Statically Allocated Strings Globally (gh-107272) (gh-110713)

Browse source

We tried this before with a dict and for all interned strings.  That ran into problems due to interpreter isolation.  However, exclusively using a per-interpreter cache caused some inconsistency that can eliminate the benefit of interning.  Here we circle back to using a global cache, but only for statically allocated strings.  We also use a more-basic _Py_hashtable_t for that global cache instead of a dict.

Ideally we would only have the global cache, but the optional isolation of each interpreter's allocator means that a non-static string object must not outlive its interpreter.  Thus we would have to store a copy of each such interned string in the global cache, tied to the main interpreter.

(cherry-picked from commit b72947a8d2)

...

This commit is contained in:

Eric Snow 2023-11-27 16:51:12 -07:00 • committed by GitHub

parent 60a08e6ff2

commit 4f71f1680d

No known key found for this signature in database

GPG key ID: 4AEE18F83AFDEB23

11 changed files with 4324 additions and 4186 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

8385

Doc/data/python3.12.abi

View file

File diff suppressed because it is too large Load diff