mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-07-19 01:05:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Some far-reaching naming changes:

Browse source 
* Command method 'find_peer()' -> 'get_finalized_command()'
  * Command method 'run_peer()' -> 'run_command()'
Also deleted the 'get_command_option()' method from Command, and
  fixed the one place where it was used (in "bdist_dumb").
This commit is contained in:
Greg Ward 2000-05-27 17:27:23 +00:00
parent 25bfd0e8d0
commit 4fb29e55f8
11 changed files with 59 additions and 78 deletions
Download patch file Download diff file Expand all files Collapse all files

30
Lib/distutils/cmd.py
View file

@ -69,11 +69,11 @@ class Command:
# none of that complicated bureaucracy is needed.
self.help = 0
# 'ready' records whether or not 'finalize_options()' has been
# 'finalized' records whether or not 'finalize_options()' has been
# called. 'finalize_options()' itself should not pay attention to
# this flag: it is the business of 'ensure_ready()', which always
# calls 'finalize_options()', to respect/update it.
self.ready = 0
# this flag: it is the business of 'ensure_finalized()', which
# always calls 'finalize_options()', to respect/update it.
self.finalized = 0
# __init__ ()
@ -89,10 +89,10 @@ class Command:
raise AttributeError, attr
def ensure_ready (self):
if not self.ready:
def ensure_finalized (self):
if not self.finalized:
self.finalize_options ()
self.ready = 1
self.finalized = 1
# Subclasses must define:
@ -184,32 +184,24 @@ class Command:
# Option_pairs: list of (src_option, dst_option) tuples
src_cmd_obj = self.distribution.get_command_obj (src_cmd)
src_cmd_obj.ensure_ready ()
src_cmd_obj.ensure_finalized ()
for (src_option, dst_option) in option_pairs:
if getattr (self, dst_option) is None:
setattr (self, dst_option,
getattr (src_cmd_obj, src_option))
def find_peer (self, command, create=1):
def get_finalized_command (self, command, create=1):
"""Wrapper around Distribution's 'get_command_obj()' method:
find (create if necessary and 'create' is true) the command
object for 'command'.."""
cmd_obj = self.distribution.get_command_obj (command, create)
cmd_obj.ensure_ready ()
cmd_obj.ensure_finalized ()
return cmd_obj
def get_peer_option (self, command, option):
"""Find or create the command object for 'command', and return
its 'option' option."""
cmd_obj = self.find_peer (command)
return getattr(cmd_obj, option)
def run_peer (self, command):
def run_command (self, command):
"""Run some other command: uses the 'run_command()' method of
Distribution, which creates the command object if necessary
and then invokes its 'run()' method."""