bpo-31752: Fix possible crash in timedelta constructor called with custom integers. (#3947)

Bad remainder in divmod() in intermediate calculations caused an assertion failure.
This commit is contained in:
Serhiy Storchaka 2017-10-23 17:12:28 +03:00 committed by GitHub
parent 7fed7bd8bb
commit 4ffd4653a7
3 changed files with 28 additions and 2 deletions

View file

@ -886,6 +886,26 @@ class TestTimeDelta(HarmlessMixedComparison, unittest.TestCase):
with self.assertRaises(ValueError):
timedelta() * get_bad_float(bad_ratio)
def test_issue31752(self):
# The interpreter shouldn't crash because divmod() returns negative
# remainder.
class BadInt(int):
def __mul__(self, other):
return Prod()
class Prod:
def __radd__(self, other):
return Sum()
class Sum(int):
def __divmod__(self, other):
# negative remainder
return (0, -1)
timedelta(microseconds=BadInt(1))
timedelta(hours=BadInt(1))
timedelta(weeks=BadInt(1))
#############################################################################
# date tests