[3.13] gh-122546: use same filename for different exceptions in new repl (GH-123217) (#123226)

This commit is contained in:
Sergey B Kirpichev 2024-08-23 02:28:09 +03:00 committed by GitHub
parent 5148e03f0f
commit 5271f8fead
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 14 additions and 11 deletions

View file

@ -162,7 +162,7 @@ class InteractiveColoredConsole(code.InteractiveConsole):
self.can_colorize = _colorize.can_colorize()
def showsyntaxerror(self, filename=None, **kwargs):
super().showsyntaxerror(colorize=self.can_colorize, **kwargs)
super().showsyntaxerror(filename=filename, **kwargs)
def showtraceback(self):
super().showtraceback(colorize=self.can_colorize)

View file

@ -113,16 +113,7 @@ class InteractiveInterpreter:
sys.last_value = value
sys.last_traceback = tb
if filename and type is SyntaxError:
# Work hard to stuff the correct filename in the exception
try:
msg, (dummy_filename, lineno, offset, line) = value.args
except ValueError:
# Not the format we expect; leave it alone
pass
else:
# Stuff in the right filename
value = SyntaxError(msg, (filename, lineno, offset, line))
sys.last_exc = sys.last_value = value
value.filename = filename
# Set the line of text that the exception refers to
source = kwargs.pop('source', '')
lines = source.splitlines()

View file

@ -1100,6 +1100,16 @@ class TestMain(TestCase):
self.assertIn("spam", output)
self.assertNotEqual(pathlib.Path(hfile.name).stat().st_size, 0)
@force_not_colorized
def test_correct_filename_in_syntaxerrors(self):
env = os.environ.copy()
commands = "a b c\nexit()\n"
output, exit_code = self.run_repl(commands, env=env)
if "can't use pyrepl" in output:
self.skipTest("pyrepl not available")
self.assertIn("SyntaxError: invalid syntax", output)
self.assertIn("<python-input-0>", output)
def run_repl(
self,
repl_input: str | list[str],

View file

@ -0,0 +1,2 @@
Consistently use same file name for different exceptions in the new repl.
Patch by Sergey B Kirpichev.