mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-22 17:55:18 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 15

gh-104144: Skip scheduling a done callback if a TaskGroup task completes eagerly (#104140)

Browse source 
Co-authored-by: Carl Meyer <carl@oddbird.net>
This commit is contained in:
Itamar Ostricher 2023-05-05 16:44:03 -07:00 • committed by GitHub
parent f3e7eb48f8
commit 52d8f36e8c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Lib/asyncio/taskgroups.py
View file

@ -164,8 +164,14 @@ class TaskGroup:
else: else:
task = self._loop.create_task(coro, context=context) task = self._loop.create_task(coro, context=context)
tasks._set_task_name(task, name) tasks._set_task_name(task, name)
task.add_done_callback(self._on_task_done) # optimization: Immediately call the done callback if the task is
self._tasks.add(task) # already done (e.g. if the coro was able to complete eagerly),
# and skip scheduling a done callback
if task.done():
self._on_task_done(task)
else:
self._tasks.add(task)
task.add_done_callback(self._on_task_done)
return task return task
# Since Python 3.8 Tasks propagate all exceptions correctly, # Since Python 3.8 Tasks propagate all exceptions correctly,

1
Misc/NEWS.d/next/Library/2023-05-03-16-51-53.gh-issue-104144.653Q0P.rst Normal file
View file

@ -0,0 +1 @@
Optimize :class:`asyncio.TaskGroup` when using :func:`asyncio.eager_task_factory`. Skip scheduling done callbacks when all tasks finish without blocking.