mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-12-11 19:40:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

inspect.Signauture.from_function: validate duck functions in Signature constructor #17159

Browse source
This commit is contained in:
Yury Selivanov 2014-01-31 15:21:51 -05:00
parent 63da7c7b0c
commit 5334bcdf97
1 changed files with 11 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Lib/inspect.py
View file

@ -2097,10 +2097,14 @@ class Signature:
def from_function(cls, func): def from_function(cls, func):
'''Constructs Signature for the given python function''' '''Constructs Signature for the given python function'''
if not (isfunction(func) or _signature_is_functionlike(func)): is_duck_function = False
# If it's not a pure Python function, and not a duck type if not isfunction(func):
# of pure function: if _signature_is_functionlike(func):
raise TypeError('{!r} is not a Python function'.format(func)) is_duck_function = True
else:
# If it's not a pure Python function, and not a duck type
# of pure function:
raise TypeError('{!r} is not a Python function'.format(func))
Parameter = cls._parameter_cls Parameter = cls._parameter_cls
@ -2164,9 +2168,11 @@ class Signature:
parameters.append(Parameter(name, annotation=annotation, parameters.append(Parameter(name, annotation=annotation,
kind=_VAR_KEYWORD)) kind=_VAR_KEYWORD))
# Is 'func' is a pure Python function - don't validate the
# parameters list (for correct order and defaults), it should be OK.
return cls(parameters, return cls(parameters,
return_annotation=annotations.get('return', _empty), return_annotation=annotations.get('return', _empty),
__validate_parameters__=False) __validate_parameters__=is_duck_function)
@classmethod @classmethod
def from_builtin(cls, func): def from_builtin(cls, func):