mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-12-04 00:30:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

fix possible if unlikely leak

Browse source
This commit is contained in:
Benjamin Peterson 2011-12-20 13:29:45 -06:00
parent 0f1e3ac897
commit 53aa1d7c57
1 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Objects/unicodeobject.c
View file

@ -8888,9 +8888,13 @@ unicode_maketrans(PyUnicodeObject *null, PyObject *args)
/* create entries for translating chars in x to those in y */ /* create entries for translating chars in x to those in y */
for (i = 0; i < PyUnicode_GET_SIZE(x); i++) { for (i = 0; i < PyUnicode_GET_SIZE(x); i++) {
key = PyLong_FromLong(PyUnicode_AS_UNICODE(x)[i]); key = PyLong_FromLong(PyUnicode_AS_UNICODE(x)[i]);
value = PyLong_FromLong(PyUnicode_AS_UNICODE(y)[i]); if (!key)
if (!key || !value)
goto err; goto err;
value = PyLong_FromLong(PyUnicode_AS_UNICODE(y)[i]);
if (!value) {
Py_DECREF(key);
goto err;
}
res = PyDict_SetItem(new, key, value); res = PyDict_SetItem(new, key, value);
Py_DECREF(key); Py_DECREF(key);
Py_DECREF(value); Py_DECREF(value);