mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-07-15 23:35:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Remove PyFloat_AsReprString() and PyFloat_AsString() which should not

Browse source 
have been public due to passing buffers without lengths.
This commit is contained in:
Neal Norwitz 2006-12-28 04:45:06 +00:00
parent 51d00223c3
commit 545686b279
3 changed files with 27 additions and 61 deletions
Download patch file Download diff file Expand all files Collapse all files

26
Python/marshal.c
View file

@ -182,8 +182,8 @@ w_object(PyObject *v, WFILE *p)
}
else {
char buf[256]; /* Plenty to format any double */
PyFloat_AsReprString(buf, (PyFloatObject *)v);
n = strlen(buf);
n = _PyFloat_Repr(PyFloat_AS_DOUBLE(v),
buf, sizeof(buf));
w_byte(TYPE_FLOAT, p);
w_byte((int)n, p);
w_string(buf, (int)n, p);
@ -209,28 +209,14 @@ w_object(PyObject *v, WFILE *p)
}
else {
char buf[256]; /* Plenty to format any double */
PyFloatObject *temp;
w_byte(TYPE_COMPLEX, p);
temp = (PyFloatObject*)PyFloat_FromDouble(
PyComplex_RealAsDouble(v));
if (!temp) {
p->error = 1;
return;
}
PyFloat_AsReprString(buf, temp);
Py_DECREF(temp);
n = _PyFloat_Repr(PyComplex_RealAsDouble(v),
buf, sizeof(buf));
n = strlen(buf);
w_byte((int)n, p);
w_string(buf, (int)n, p);
temp = (PyFloatObject*)PyFloat_FromDouble(
PyComplex_ImagAsDouble(v));
if (!temp) {
p->error = 1;
return;
}
PyFloat_AsReprString(buf, temp);
Py_DECREF(temp);
n = strlen(buf);
n = _PyFloat_Repr(PyComplex_ImagAsDouble(v),
buf, sizeof(buf));
w_byte((int)n, p);
w_string(buf, (int)n, p);
}