mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-09-30 12:21:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

regrtest: always show before/after of modified env (#1192) (#1406)

Browse source 
Buildbots don't run tests with -vv and so only log "xxx was modified
by test_xxx" which is not enough to debug such random issue. In many
cases, I'm unable to reproduce the warning and so unable to fix it.

Always logging the value before and value after should help to debug
such warning on buildbots.
(cherry picked from commit ec4b17239d)
This commit is contained in:
Victor Stinner 2017-05-03 02:12:22 +02:00 • committed by GitHub
parent 0c2ff0898d
commit 564e89f43b
1 changed files with 2 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Lib/test/libregrtest/save_env.py
View file

@ -279,7 +279,6 @@ class saved_test_environment:
if not self.quiet and not self.pgo: if not self.quiet and not self.pgo:
print(f"Warning -- {name} was modified by {self.testname}", print(f"Warning -- {name} was modified by {self.testname}",
file=sys.stderr, flush=True) file=sys.stderr, flush=True)
if self.verbose > 1:
print(f" Before: {original}\n After: {current} ", print(f" Before: {original}\n After: {current} ",
file=sys.stderr, flush=True) file=sys.stderr, flush=True)
return False return False