Rename Transport.pause/resume to pause_reading/pause_writing. Also relax timeout in test_call_later().

This commit is contained in:
Guido van Rossum 2013-10-18 07:58:20 -07:00
parent 40b22d0661
commit 57497ad181
10 changed files with 33 additions and 33 deletions

View file

@ -94,12 +94,12 @@ class _ProactorReadPipeTransport(_ProactorBasePipeTransport,
self._paused = False
self._loop.call_soon(self._loop_reading)
def pause(self):
assert not self._closing, 'Cannot pause() when closing'
def pause_reading(self):
assert not self._closing, 'Cannot pause_reading() when closing'
assert not self._paused, 'Already paused'
self._paused = True
def resume(self):
def resume_reading(self):
assert self._paused, 'Not paused'
self._paused = False
if self._closing:

View file

@ -406,13 +406,13 @@ class _SelectorSocketTransport(_SelectorTransport):
if waiter is not None:
self._loop.call_soon(waiter.set_result, None)
def pause(self):
assert not self._closing, 'Cannot pause() when closing'
def pause_reading(self):
assert not self._closing, 'Cannot pause_reading() when closing'
assert not self._paused, 'Already paused'
self._paused = True
self._loop.remove_reader(self._sock_fd)
def resume(self):
def resume_reading(self):
assert self._paused, 'Not paused'
self._paused = False
if self._closing:
@ -590,19 +590,19 @@ class _SelectorSslTransport(_SelectorTransport):
if self._waiter is not None:
self._loop.call_soon(self._waiter.set_result, None)
def pause(self):
def pause_reading(self):
# XXX This is a bit icky, given the comment at the top of
# _on_ready(). Is it possible to evoke a deadlock? I don't
# know, although it doesn't look like it; write() will still
# accept more data for the buffer and eventually the app will
# call resume() again, and things will flow again.
# call resume_reading() again, and things will flow again.
assert not self._closing, 'Cannot pause() when closing'
assert not self._closing, 'Cannot pause_reading() when closing'
assert not self._paused, 'Already paused'
self._paused = True
self._loop.remove_reader(self._sock_fd)
def resume(self):
def resume_reading(self):
assert self._paused, 'Not paused'
self._paused = False
if self._closing:

View file

@ -106,7 +106,7 @@ class StreamReader:
def _maybe_resume_transport(self):
if self._paused and self.byte_count <= self.limit:
self._paused = False
self._transport.resume()
self._transport.resume_reading()
def feed_eof(self):
self.eof = True
@ -133,7 +133,7 @@ class StreamReader:
not self._paused and
self.byte_count > 2*self.limit):
try:
self._transport.pause()
self._transport.pause_reading()
except NotImplementedError:
# The transport can't be paused.
# We'll just have to buffer all data.

View file

@ -29,15 +29,15 @@ class BaseTransport:
class ReadTransport(BaseTransport):
"""ABC for read-only transports."""
def pause(self):
def pause_reading(self):
"""Pause the receiving end.
No data will be passed to the protocol's data_received()
method until resume() is called.
method until resume_reading() is called.
"""
raise NotImplementedError
def resume(self):
def resume_reading(self):
"""Resume the receiving end.
Data received will once again be passed to the protocol's

View file

@ -232,10 +232,10 @@ class _UnixReadPipeTransport(transports.ReadTransport):
self._loop.call_soon(self._protocol.eof_received)
self._loop.call_soon(self._call_connection_lost, None)
def pause(self):
def pause_reading(self):
self._loop.remove_reader(self._fileno)
def resume(self):
def resume_reading(self):
self._loop.add_reader(self._fileno, self._read_ready)
def close(self):