mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-09-26 18:29:57 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

Now that list.extend() is at the root of many list operations, it becomes

Browse source 
worth it to in-line the call to PyIter_Next().

Saves another 15% on most list operations that acceptable a general
iterable argument (such as the list constructor).
This commit is contained in:
Raymond Hettinger 2004-03-11 09:48:18 +00:00
parent 8ca92ae54c
commit 57c4542bcd
1 changed files with 9 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Objects/listobject.c
View file

@ -715,6 +715,7 @@ listextend(PyListObject *self, PyObject *b)
int n; /* guess for size of b */ int n; /* guess for size of b */
int mn; /* m + n */ int mn; /* m + n */
int i; int i;
PyObject *(*iternext)(PyObject *);
/* Special cases: /* Special cases:
1) lists and tuples which can use PySequence_Fast ops 1) lists and tuples which can use PySequence_Fast ops
@ -732,6 +733,7 @@ listextend(PyListObject *self, PyObject *b)
it = PyObject_GetIter(b); it = PyObject_GetIter(b);
if (it == NULL) if (it == NULL)
return NULL; return NULL;
iternext = *it->ob_type->tp_iternext;
/* Guess a result list size. */ /* Guess a result list size. */
n = PyObject_Size(b); n = PyObject_Size(b);
@ -747,10 +749,14 @@ listextend(PyListObject *self, PyObject *b)
/* Run iterator to exhaustion. */ /* Run iterator to exhaustion. */
for (i = m; ; i++) { for (i = m; ; i++) {
PyObject *item = PyIter_Next(it); PyObject *item = iternext(it);
if (item == NULL) { if (item == NULL) {
if (PyErr_Occurred()) if (PyErr_Occurred()) {
if (PyErr_ExceptionMatches(PyExc_StopIteration))
PyErr_Clear();
else
goto error; goto error;
}
break; break;
} }
if (i < mn) if (i < mn)